From 1c5fc2e4364063884f33b78f45f351201705fae4 Mon Sep 17 00:00:00 2001 From: Martin Kagamino Lehoux Date: Thu, 27 Aug 2026 11:32:31 +0200 Subject: Tame the deadcode gate and remove dead web helpers Run deadcode with -test and without the vendored node_modules package so the check reports only genuinely unreachable code instead of test-only helpers and vendored functions. Remove the three web helpers it still flagged (formatBikeType, formatRideType, dataQualityURL) that had no callers. Apply the go fix modernizations the check gate performs (range-over-int loops and embedded-field composite literals) that the gate had rewritten in the working tree. --- climb/detection.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'climb/detection.go') diff --git a/climb/detection.go b/climb/detection.go index 1efe1c5..9269c2f 100644 --- a/climb/detection.go +++ b/climb/detection.go @@ -127,7 +127,7 @@ func bestClimbBetween(distances, elevations []float64, minSlope float64) (core.I bestDetectionScore := climbDetectionScore(distances, elevations) best := core.NewInterval(0, end) - for i := 0; i < end; i++ { + for i := range end { detectionScore := climbDetectionScore(distances[i:end], elevations[i:end]) if detectionScore > bestDetectionScore { best.Start = i @@ -155,7 +155,7 @@ func bestClimbBetween(distances, elevations []float64, minSlope float64) (core.I // Classic best too gentle: re-segment into the best qualifying sub-segment. bestDetectionScore = math.Inf(-1) best = core.NewInterval(-1, -1) - for i := 0; i < end; i++ { + for i := range end { for j := i + 1; j <= end; j++ { if Slope(distances[i:j+1], elevations[i:j+1]) < minSlope { continue -- cgit v1.3