From e54e2b313a37c2d2af4e3e537ad4e64e8c816e86 Mon Sep 17 00:00:00 2001 From: Martin Kagamino Lehoux Date: Tue, 25 Aug 2026 11:34:27 +0200 Subject: Remove per-index ride accessors now dead after the component migration The DistanceM, ElevationM, Coord, Timestamp and optional metric index accessors (HeartRateBpm, CadenceRpm, PowerW) are no longer used by any production code now that algorithms and consumers read ride components. Tests that asserted metric parsing and coordinates now read the component slices (Distances, Coords, HeartRates, Cadences, Powers). --- strava/sync_test.go | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'strava/sync_test.go') diff --git a/strava/sync_test.go b/strava/sync_test.go index 9223c95..abc3d0e 100644 --- a/strava/sync_test.go +++ b/strava/sync_test.go @@ -103,13 +103,15 @@ func TestGet(t *testing.T) { parsedRide, err := (ride.GPXRideParser{}).Parse(bytes.NewReader(gpxData)) require.NoError(t, err) assert.Equal(t, 2, parsedRide.Len()) - heartRateValue, found := parsedRide.HeartRateBpm(1) - require.True(t, found) + heartRates, ok := parsedRide.HeartRates() + require.True(t, ok) + heartRateValue := heartRates[1] assert.Equal(t, 91.0, heartRateValue) - _, found = parsedRide.CadenceRpm(0) - assert.False(t, found) - powerValue, found := parsedRide.PowerW(1) - require.True(t, found) + _, ok = parsedRide.Cadences() + assert.False(t, ok) + powers, ok := parsedRide.Powers() + require.True(t, ok) + powerValue := powers[1] assert.Equal(t, 0.0, powerValue) } -- cgit v1.3