Remove per-index ride accessors now dead after the component migration

The DistanceM, ElevationM, Coord, Timestamp and optional metric index
accessors (HeartRateBpm, CadenceRpm, PowerW) are no longer used by any
production code now that algorithms and consumers read ride components.
Tests that asserted metric parsing and coordinates now read the component
slices (Distances, Coords, HeartRates, Cadences, Powers).

1 files changed, 18 insertions, 18 deletions

diff --git a/ride/parser_test.go b/ride/parser_test.go
index c2d6719..d8ac4d6 100644
--- a/ride/parser_test.go
+++ b/ride/parser_test.go
@@ -24,7 +24,7 @@ func TestGPXRideParserSkipsStationaryPoints(t *testing.T) {
 	parsed, err := (ride.GPXRideParser{}).Parse(strings.NewReader(data))
 	require.NoError(t, err)
 	assert.Equal(t, 2, parsed.Len())
-	assert.Greater(t, parsed.DistanceM(1), 0.0)
+	assert.Greater(t, parsed.Distances()[1], 0.0)
 }
 
 func TestGPXRideParserRejectsStationaryRide(t *testing.T) {
@@ -57,15 +57,15 @@ func TestGPXRideParserReadsGarminMetrics(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, 2, parsed.Len())
 
-	heartRate, found := parsed.HeartRateBpm(1)
-	require.True(t, found)
-	assert.Equal(t, 92.0, heartRate)
-	cadence, found := parsed.CadenceRpm(1)
-	require.True(t, found)
-	assert.Equal(t, 72.0, cadence)
-	power, found := parsed.PowerW(1)
-	require.True(t, found)
-	assert.Equal(t, 202.0, power)
+	heartRates, ok := parsed.HeartRates()
+	require.True(t, ok)
+	assert.Equal(t, 92.0, heartRates[1])
+	cadences, ok := parsed.Cadences()
+	require.True(t, ok)
+	assert.Equal(t, 72.0, cadences[1])
+	powers, ok := parsed.Powers()
+	require.True(t, ok)
+	assert.Equal(t, 202.0, powers[1])
 }
 
 func TestGPXRideParserDropsIncompleteMetricColumn(t *testing.T) {
@@ -77,12 +77,12 @@ func TestGPXRideParserDropsIncompleteMetricColumn(t *testing.T) {
 	parsed, err := (ride.GPXRideParser{}).Parse(strings.NewReader(data))
 	require.NoError(t, err)
 
-	_, found := parsed.CadenceRpm(0)
-	assert.False(t, found)
-	heartRate, found := parsed.HeartRateBpm(1)
-	require.True(t, found)
-	assert.Equal(t, 92.0, heartRate)
-	power, found := parsed.PowerW(1)
-	require.True(t, found)
-	assert.Equal(t, 0.0, power)
+	_, ok := parsed.Cadences()
+	assert.False(t, ok)
+	heartRates, ok := parsed.HeartRates()
+	require.True(t, ok)
+	assert.Equal(t, 92.0, heartRates[1])
+	powers, ok := parsed.Powers()
+	require.True(t, ok)
+	assert.Equal(t, 0.0, powers[1])
 }