fix(ride): use effort metrics for moving time

2 files changed, 44 insertions, 5 deletions

diff --git a/ride/moving_time.go b/ride/moving_time.go
index ea9ec24..c98e6b1 100644
--- a/ride/moving_time.go
+++ b/ride/moving_time.go
@@ -2,18 +2,22 @@ package ride
 
 import "time"
 
-const MovingTimeAlgorithmVersion = "v1"
+const MovingTimeAlgorithmVersion = "v2"
 
 // movingTimeMinSpeedMps is the minimum implied speed between two consecutive
 // track points for the interval to count as moving (0.4 km/h).
 const movingTimeMinSpeedMps = 0.4 / 3.6
 
+// movingTimeMinPowerW is the minimum power output for an interval to count as
+// moving when GPS speed is below the minimum speed.
+const movingTimeMinPowerW = 20
+
 // movingTimeMaxGap is the maximum time gap between consecutive track points
 // that can count as moving. Longer gaps are pauses (stops, lost signal).
 const movingTimeMaxGap = 120 * time.Second
 
 // Bench (356 rides, `-backtest`):
-// absMean 2.5%, bias -1.3, p50 0.8, p75 2.9, p90 6.0, p95 9.3, p99 26.2.
+// absMean 2.4%, stderr 0.2, p50 0.7, p75 2.9, p90 6.7, p95 9.6, p99 19.9.
 func MovingTime(r Ride) time.Duration {
 	return movingTime(r, movingTimeMinSpeedMps, movingTimeMaxGap)
 }
@@ -26,7 +30,16 @@ func movingTime(r Ride, minSpeedMps float64, maxGap time.Duration) time.Duration
 			continue
 		}
 		dd := r.DistanceM(i) - r.DistanceM(i-1)
-		if dd/dt.Seconds() > minSpeedMps {
+		gpsMoving := dd/dt.Seconds() > minSpeedMps
+		powerMoving := false
+		if power, ok := r.PowerW(i); ok {
+			powerMoving = power >= movingTimeMinPowerW
+		}
+		cadenceMoving := false
+		if cadence, ok := r.CadenceRpm(i); ok {
+			cadenceMoving = cadence > 0
+		}
+		if gpsMoving || powerMoving || cadenceMoving {
 			moving += dt
 		}
 	}
diff --git a/ride/moving_time_test.go b/ride/moving_time_test.go
index 402726f..06f9998 100644
--- a/ride/moving_time_test.go
+++ b/ride/moving_time_test.go
@@ -1,6 +1,7 @@
 package ride_test
 
 import (
+	"fmt"
 	"strings"
 	"testing"
 	"time"
@@ -25,6 +26,17 @@ func trackPoint(lat, lon string, timestamp string) string {
 		`</trkpt>`
 }
 
+func metricTrackPoint(lat, lon, timestamp string, cadence, power int) string {
+	return `<trkpt lat="` + lat + `" lon="` + lon + `">` +
+		`<ele>100</ele>` +
+		`<time>` + timestamp + `</time>` +
+		`<extensions><gpxtpx:TrackPointExtension>` +
+		`<gpxtpx:cad>` + fmt.Sprint(cadence) + `</gpxtpx:cad>` +
+		`<gpxtpx:watts>` + fmt.Sprint(power) + `</gpxtpx:watts>` +
+		`</gpxtpx:TrackPointExtension></extensions>` +
+		`</trkpt>`
+}
+
 func TestMovingTimeCountsSteadyRiding(t *testing.T) {
 	parsed := gpxWithPoints(t,
 		trackPoint("43.0", "5.0", "2026-01-01T10:00:00Z")+
@@ -55,6 +67,20 @@ func TestMovingTimeExcludesLunchBreak(t *testing.T) {
 	assert.Equal(t, time.Minute, ride.MovingTime(parsed))
 }
 
+func TestMovingTimeCountsEffortMetricsWhenGPSSpeedIsLow(t *testing.T) {
+	data := parserTestGPXMetricsPrefix +
+		metricTrackPoint("43.0", "5.0", "2026-01-01T10:00:00Z", 0, 0) +
+		metricTrackPoint("43.000001", "5.0", "2026-01-01T10:01:00Z", 80, 0) +
+		metricTrackPoint("43.000002", "5.0", "2026-01-01T10:02:00Z", 0, 50) +
+		metricTrackPoint("43.000003", "5.0", "2026-01-01T10:03:00Z", 0, 10) +
+		metricTrackPoint("43.000004", "5.0", "2026-01-01T10:04:00Z", 0, 0) +
+		parserTestGPXSuffix
+	parsed, err := (ride.GPXRideParser{}).Parse(strings.NewReader(data))
+	require.NoError(t, err)
+
+	assert.Equal(t, 2*time.Minute, ride.MovingTime(parsed))
+}
+
 func TestMovingTimeWithoutTimestamps(t *testing.T) {
 	data := parserTestGPXPrefix +
 		`<trkpt lat="43.0" lon="5.0"><ele>100</ele></trkpt>` +
@@ -68,5 +94,5 @@ func TestMovingTimeWithoutTimestamps(t *testing.T) {
 }
 
 func TestMovingTimeAlgorithmVersion(t *testing.T) {
-	assert.Equal(t, "v1", ride.MovingTimeAlgorithmVersion)
-}
\ No newline at end of file
+	assert.Equal(t, "v2", ride.MovingTimeAlgorithmVersion)
+}